realtek: pcs: drop PCS creation without SerDes ref
authorJonas Jelonek <[email protected]>
Thu, 11 Dec 2025 22:37:33 +0000 (22:37 +0000)
committerRobert Marko <[email protected]>
Tue, 16 Dec 2025 12:37:31 +0000 (13:37 +0100)
commita58e41e522bf5b273fa626e03546b92141731d9c
treec605ddd63ffe6c85b980b354ee1ad32ba93720d7
parent8e4730fd60a1b4998d1c9c07aeb6c6a27bce210f
realtek: pcs: drop PCS creation without SerDes ref

Since the beginning, the PCS driver had the ability to call its
rtpcs_create without a reference to a valid PCS node. A comment in the
code mentions that this is done for RTL838X and its built-in octa-PHY
which is connected directly instead of via a SerDes. Further
explanations are not provided.

Drop this ability and make the rtpcs_create call in the dsa driver
conditional. As the built-in PHY of RTL838X isn't attached to a SerDes,
there is no obvious point of having the PCS driver in that chain. The
ports are marked as internal and have no pcs-handle, thus no phylink_pcs
instance should be created.

Signed-off-by: Jonas Jelonek <[email protected]>
Link: https://github.com/openwrt/openwrt/pull/21146
Signed-off-by: Robert Marko <[email protected]>
target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/common.c
target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c